[DEPRECATION] Remove references to deprecated rand.Seed (#2650) #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhardt
commented
Sep 27, 2024
| "fmt" | ||
| "io" | ||
| mrand "math/rand" |
There was a problem hiding this comment.
This choice was questioned on orangekame's PR.
Howver, this aligns pwgen_test.go with the style found in rand.go, of the same package.
Moreover, it only affects 3 references in a single test
lhardt
force-pushed
the
fix-issue-2650
branch
from
9b672e2
to
6bfe602
Compare
AnomalRoil
previously approved these changes
Sep 27, 2024
dominikschulz
previously approved these changes
Sep 28, 2024
Signed-off-by: Léo Hardt <[email protected]>
lhardt
dismissed stale reviews from dominikschulz and AnomalRoil
via
fa4e66a
lhardt
force-pushed
the
fix-issue-2650
branch
from
6bfe602
to
fa4e66a
Compare
|
Hi! Done the linting and signoff fixes. Since this is so close to October, would you mind if I reopen the PR on Tuesday? |
|
@lhardt No problem at all. See you in #hacktober :) |
|
Will be reopening it then. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove references to deprecated rand.Seed (#2650).
Context:
math/rand.Seedis deprecated, andmath/randis already seeded by default.math/rand.Seedwill be a no-op, breaking the testTestPwgenNoCrand.See method documentation in the link above for further info.
Code Changes:
Randvariable, so that its value can be injected in tests;TestPwgenNoCrandtoTestPwgenNoCrandFallback, to make the expected behaviour clearer;Shreddoes not need to seed, nor doesTestLoadFromEnvin config_test,TestPwgenNoCrandFallbackmust restore the randomness so thatTestLoadFromEnvcan work properly.This also removes the side-effect that fsutil's Shred was overwriting the seed set by pwgen.